Под спойлером. Увы, не последняя версия, тут где-то половина
Bad Code Hall of Fame
From XXXXXXX.cs (PowerUser property is Boolean)
if (objTransaction.PowerUser.ToString().ToLower() == "True".ToString().ToLower())
From XXXXXXX.csif(condition1){
doSomething()
};
else if(condition2){
doSomething()
};
else if(condition3){
doSomething()
};
else if(condition4){
doSomething()
};
in all 4 cases the performed operation is the same
From some other modulesconnection = objCommon.OpenConnection();
transaction = connection.BeginTransaction();
… Operations with the detail table data are performed …
If(somethingIsWrong){
transaction.RollBack();
objCommon.CloseConnection(); // CONNECTION IS CLOSED
};
Further operations with the master table data are performed on the same connection & transaction without their status check
From XXXXXXX.csif (returnStatus == Constant.RECORD_ALREADY_EXIST) {
objOutBusinessEntity.HashTableValue.Add(Constant.RETURN_ID, objBusinessEntity.HashTableValue[Constant.QUERY_PARAM1].ToString());
transaction.Rollback();
objCommon.CloseConnection(connection);
transactionClosed = true;
}
else if (returnStatus == Constant.RECORD_ALREADY_EXIST){ objOutBusinessEntity.HashTableValue.Add(Constant.RETURN_ID, objBusinessEntity.HashTableValue[Constant.QUERY_PARAM2].ToString());
transaction.Rollback();
objCommon.CloseConnection(connection);
transactionClosed = true;
}
From XXXXXXX.cs private DataSet AddLabourColumns(DataSet dsTemp)
{
DataColumn dc;
try{
for (int columnCount = 0; columnCount 0)
{
alGroupCodes.Add("Project WBS");
alGroupCodes.Add("Project WBS 1");
}
if (iProjectCount > 1)
{
alGroupCodes.Add("Project WBS 2");
}
if (iProjectCount > 2)
{
alGroupCodes.Add("Project WBS 3");
}
if (iProjectCount > 3)
{
alGroupCodes.Add("Project WBS 4");
}
if (iProjectCount > 4)
{
alGroupCodes.Add("Project WBS 5");
}
if (iProjectCount > 5)
{
alGroupCodes.Add("Project WBS 6");
}
if (iProjectCount > 6)
{
alGroupCodes.Add("Project WBS 7");
}
if (iProjectCount > 7)
{
alGroupCodes.Add("Project WBS 8");
}
if (iProjectCount >
{
alGroupCodes.Add("Project WBS 9");
}
if (iProjectCount > 9)
{
alGroupCodes.Add("Project WBS 10");
}
if (iProjectCount > 10)
{
alGroupCodes.Add("Project WBS 11");
}
if (iProjectCount > 11)
{
alGroupCodes.Add("Project WBS 12");
}
if (iProjectCount > 12)
{
alGroupCodes.Add("Project WBS 13");
}
alGroupCodes.Add("COA");
alGroupCodes.Add("COA 1");
alGroupCodes.Add("COA 2");
alGroupCodes.Add("COA 3");
alGroupCodes.Add("COA 4");
return alGroupCodes;
}
catch (Exception Ex)
{
throw Ex;
}
}
From ZZZZZZZZZZZZZZ.csTry
{
if (rdbField.Checked.ToString().Trim().ToLower() == Constant.TRUE.ToLower())
{
cmbField.Enabled = true;
}
else
{
cmbField.Enabled = false;
}
}
catch (Exception Ex)
{
ShowMessageBox(Ex.Message, FORM_NAME, Constant.MESSAGEBOX_ERROR);
//Log error into text file.
LogHelper.LogError("InControl.Search Data.rdbField_CheckedChanged: " + Ex.Message, objTransactionEntity);
}
From YYYYYYYYYYYYYY.cs
The following code checks if certain ID is present in a dataset by LOOPING through the whole dataset. The most interesting thing is even if search value is found, LOOPING IS CONTINUING.
public int SearchActivityID(
string CtrID)
{
int returnVal = CONST_DOESNOTEXIST;
try {
foreach (DataRow theRow
in dsLookup.Tables[Constant.TAB_PROJ_ACTIVITY].Rows)
{
if (Convert.ToString(theRow[CONST_CTR_ID]).Trim() == CtrID)
{
returnVal = CONST_EXISTS;
}
}
return returnVal;
}
catch (Exception Ex)
{
Cursor.Current = Cursors.Default;
ShowMessageBox(Ex.Message, "Variation Control", Constant.MESSAGEBOX_ERROR);
//Log error into text file.
LogHelper.LogError("InControl.VariationControl.SearchActivityID: " + Ex.Message, _transactionEntity);
ClearEntity();
return returnVal;
}
}
From XXXXXXXXXX.cs
private void dxGvCapitalCost_FocusedColumnChanged(
object sender, FocusedColumnChangedEventArgs e)
{
try {
string selectedCol =
string.Empty;
if (dxGvCapitalCost.FocusedColumn !=
null)
{
selectedCol = dxGvCapitalCost.FocusedColumn.FieldName.Trim();
}
// OK, the selected column name is read, it’s in the
original case
if (selectedCol == colCapitalProjectWBSLevel1.ToString().
ToLower().Trim())
{
}
// Here the selected column name is compared with certain value LOWERCASE.
else if (selectedCol == colCapitalProjectWBSLevel2.ToString().
ToLower().Trim())
{
}
// multiple repetitions
else if (selectedCol == COL_CAPITAL_WBS_DESC.ToLower().Trim())
{
}
}
catch (Exception Ex)
{
// This is curious too. What is the reason to place public property value change // into a try..catch structure?
//Log error into text file.
}
}